Re: [PATCH] dimlib: make DIMLIB a hidden symbol

[Uwe Kleine-KÃnig]

Hello,

On 9/20/19 7:02 PM, Tal Gilboa wrote:
> On 9/20/2019 4:31 PM, Uwe Kleine-KÃnig wrote:
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index cc04124ed8f7..9fe8a21fd183 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -555,8 +555,7 @@ config SIGNATURE
>>   	  Implementation is done using GnuPG MPI library
>>   
>>   config DIMLIB
>> -	bool "DIM library"
>> -	default y
>> +	bool
>>   	help
>>   	  Dynamic Interrupt Moderation library.
>>   	  Implements an algorithm for dynamically change CQ moderation values
>>
> There's a pending series using DIM which didn't add the select clause 
> [1]. Arthur, FYI. Other than that LGTM.

IMHO this should be fixed, as otherwise the config with the new code
enabled and DIMLIB disabled will fail to build also without my change.

Best regards
Uwe

Attachment: signature.asc
Description: OpenPGP digital signature