Re: [PATCH 3.16 000/132] 3.16.74-rc1 review

[Ben Hutchings]

On Fri, 2019-09-20 at 13:04 -0700, Guenter Roeck wrote:
> On Fri, Sep 20, 2019 at 03:23:34PM +0100, Ben Hutchings wrote:
> > This is the start of the stable review cycle for the 3.16.74 release.
> > There are 132 patches in this series, which will be posted as responses
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Mon Sep 23 20:00:00 UTC 2019.
> > Anything received after that time might be too late.
> > 
> 
> Build results:
> 	total: 136 pass: 135 fail: 1
> Failed builds:
> 	arm:allmodconfig
> Qemu test results:
> 	total: 229 pass: 229 fail: 0
> 
> Build errors in arm:allmodconfig are along the line of
> 
> In file included from include/linux/printk.h:5,
>                  from include/linux/kernel.h:13,
>                  from include/linux/clk.h:16,
>                  from drivers/gpu/drm/tilcdc/tilcdc_drv.h:21,
>                  from drivers/gpu/drm/tilcdc/tilcdc_drv.c:20:
> include/linux/init.h:343:7: error: 'cleanup_module'
> 	specifies less restrictive attribute than its target 'tilcdc_drm_fini': 'cold'
> 
> In addition to a few errors like that, there are literally thousands
> of similar warnings.

It looks like this is triggered by you switching arm builds from gcc 8
to 9, rather than by any code change.

Does it actually make sense to try to support building Linux 3.16 with
gcc 9?  If so, I suppose I'll need to add:

commit edc966de8725f9186cc9358214da89d335f0e0bd
Author: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
Date:   Fri Aug 2 12:37:56 2019 +0200

    Backport minimal compiler_attributes.h to support GCC 9

commit a6e60d84989fa0e91db7f236eda40453b0e44afa
Author: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
Date:   Sat Jan 19 20:59:34 2019 +0100

    include/linux/module.h: copy __init/__exit attrs to init/cleanup_module

Ben.

-- 
Ben Hutchings
Nothing is ever a complete failure;
it can always serve as a bad example.

Attachment: signature.asc
Description: This is a digitally signed message part