Re: [PATCH RFC v3 1/9] ACPI: NUMA: export pxm_to_node

From: Michal Hocko
Date: Mon Sep 23 2019 - 06:36:59 EST


On Mon 23-09-19 12:13:11, David Hildenbrand wrote:
> On 19.09.19 16:22, David Hildenbrand wrote:
> > Will be needed by virtio-mem to identify the node from a pxm.
> >
> > Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
> > Cc: Len Brown <lenb@xxxxxxxxxx>
> > Cc: linux-acpi@xxxxxxxxxxxxxxx
> > Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> > ---
> > drivers/acpi/numa.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/acpi/numa.c b/drivers/acpi/numa.c
> > index eadbf90e65d1..d5847fa7ac69 100644
> > --- a/drivers/acpi/numa.c
> > +++ b/drivers/acpi/numa.c
> > @@ -35,6 +35,7 @@ int pxm_to_node(int pxm)
> > return NUMA_NO_NODE;
> > return pxm_to_node_map[pxm];
> > }
> > +EXPORT_SYMBOL(pxm_to_node);
>
> FWIW, this is a fairly old patch I dragged along and I think I'll
> convert this to EXPORT_SYMBOL_GPL now that I know better :)

All other exports in this file are EXPORT_SYMBOL. Why is this one
considered special to restrict the access?
--
Michal Hocko
SUSE Labs