Re: [PATCH v2 3/9] csky: entry: Remove unneeded need_resched() loop
From: Guo Ren
Date: Mon Sep 23 2019 - 12:56:02 EST
Ok, I'll put in my tree :)
On Mon, Sep 23, 2019 at 10:36 PM Valentin Schneider
<valentin.schneider@xxxxxxx> wrote:
>
> Since the enabling and disabling of IRQs within preempt_schedule_irq()
> is contained in a need_resched() loop, we don't need the outer arch
> code loop.
>
> Acked-by: Guo Ren <guoren@xxxxxxxxxx>
> Signed-off-by: Valentin Schneider <valentin.schneider@xxxxxxx>
> ---
> arch/csky/kernel/entry.S | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/csky/kernel/entry.S b/arch/csky/kernel/entry.S
> index a7e84ccccbd8..679afbcc2001 100644
> --- a/arch/csky/kernel/entry.S
> +++ b/arch/csky/kernel/entry.S
> @@ -292,11 +292,7 @@ ENTRY(csky_irq)
> ldw r8, (r9, TINFO_FLAGS)
> btsti r8, TIF_NEED_RESCHED
> bf 2f
> -1:
> jbsr preempt_schedule_irq /* irq en/disable is done inside */
> - ldw r7, (r9, TINFO_FLAGS) /* get new tasks TI_FLAGS */
> - btsti r7, TIF_NEED_RESCHED
> - bt 1b /* go again */
> #endif
> 2:
> jmpi ret_from_exception
> --
> 2.22.0
>
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/