Re: [PATCH] smack: fix an compile error in smack_post_notification

From: Casey Schaufler
Date: Mon Sep 23 2019 - 17:49:28 EST


On 9/22/2019 8:16 PM, zhong jiang wrote:
> I hit the following error when compile the kernel.

What tree/branch are you working with? I don't see this.

>
> security/smack/smack_lsm.c: In function smack_post_notification:
> security/smack/smack_lsm.c:4383:7: error: dereferencing pointer to incomplete type struct watch_notification
> if (n->type == WATCH_TYPE_META)
> ^~
> security/smack/smack_lsm.c:4383:17: error: WATCH_TYPE_META undeclared (first use in this function); did you mean TCA_PIE_BETA?
> if (n->type == WATCH_TYPE_META)
> ^~~~~~~~~~~~~~~
> TCA_PIE_BETA
> security/smack/smack_lsm.c:4383:17: note: each undeclared identifier is reported only once for each function it appears in
>
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
> ---
> security/smack/smack.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index 62529f3..02b05a2 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -21,6 +21,7 @@
> #include <linux/rculist.h>
> #include <linux/lsm_audit.h>
> #include <linux/msg.h>
> +#include <linux/watch_queue.h>
>
> /*
> * Use IPv6 port labeling if IPv6 is enabled and secmarks