Re: [RFC PATCH 2/4] iommu/vt-d: Add first level page table interfaces

[Lu Baolu]

Hi Ashok,

On 9/24/19 4:31 AM, Raj, Ashok wrote:
> On Mon, Sep 23, 2019 at 08:24:52PM +0800, Lu Baolu wrote:
> > This adds functions to manipulate first level page tables
> > which could be used by a scalale mode capable IOMMU unit.
>
> s/scalale/scalable

Yes.

> > intel_mmmap_range(domain, addr, end, phys_addr, prot)
>
> Maybe think of a different name..? mmmap seems a bit weird :-)

Yes. I don't like it either. I've thought about it and haven't
figured out a satisfied one. Do you have any suggestions?

Best regards,
Baolu

> >   - Map an iova range of [addr, end) to the physical memory
> >     started at @phys_addr with the @prot permissions.
> >
> > intel_mmunmap_range(domain, addr, end)
> >   - Tear down the map of an iova range [addr, end). A page
> >     list will be returned which will be freed after iotlb
> >     flushing.
> >
> > Cc: Ashok Raj <ashok.raj@xxxxxxxxx>
> > Cc: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> > Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
> > Cc: Liu Yi L <yi.l.liu@xxxxxxxxx>
> > Cc: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
> > Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>