Re: [PATCH v2 7/7] random: Remove kernel.random.read_wakeup_threshold

[Eric W. Biederman]

Jann Horn <jannh@xxxxxxxxxx> writes:

> On Fri, Sep 20, 2019 at 4:37 PM Andy Lutomirski <luto@xxxxxxxxxx> wrote:
>> It has no effect any more, so remove it.  We can revert this if
>> there is some user code that expects to be able to set this sysctl.
>>
>> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
>> ---
>>  drivers/char/random.c | 18 +-----------------
>>  1 file changed, 1 insertion(+), 17 deletions(-)
>>
>> diff --git a/drivers/char/random.c b/drivers/char/random.c
> [...]
>> -       {
>> -               .procname       = "read_wakeup_threshold",
>
> There's a line in bin_random_table in kernel/sysctl_binary.c that
> refers to this sysctl, that should probably also be deleted?

I think it should be safe to leave in kernel/sysctl_binary.c

This reminds me.  I think we may finally be at a point where we can
remove practically all of kernel/sysctl_binary.c

I need to double check but last I looked no distro enables
COINFIG_SYSCTL_SYSCALL anymore.  Ubunutu was the last distro I know of
that enabled it, and I think it has been a year or more since Ubuntu
disabled CONFIG_SYSCTL_SYSCALL.

Eric