Re: [Patch v5 4/8] media: i2c: ov2659: fix s_stream return value

[Lad, Prabhakar]

On Mon, Sep 30, 2019 at 2:07 PM Benoit Parrot <bparrot@xxxxxx> wrote:
>
> In ov2659_s_stream() return value for invoked function should be checked
> and propagated.
>
> Signed-off-by: Benoit Parrot <bparrot@xxxxxx>
> ---
>  drivers/media/i2c/ov2659.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
>
Acked-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>

Cheers,
--Prabhakar Lad

> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
> index f77320e8a60d..da181a13cf44 100644
> --- a/drivers/media/i2c/ov2659.c
> +++ b/drivers/media/i2c/ov2659.c
> @@ -1187,11 +1187,15 @@ static int ov2659_s_stream(struct v4l2_subdev *sd, int on)
>                 goto unlock;
>         }
>
> -       ov2659_set_pixel_clock(ov2659);
> -       ov2659_set_frame_size(ov2659);
> -       ov2659_set_format(ov2659);
> -       ov2659_set_streaming(ov2659, 1);
> -       ov2659->streaming = on;
> +       ret = ov2659_set_pixel_clock(ov2659);
> +       if (!ret)
> +               ret = ov2659_set_frame_size(ov2659);
> +       if (!ret)
> +               ret = ov2659_set_format(ov2659);
> +       if (!ret) {
> +               ov2659_set_streaming(ov2659, 1);
> +               ov2659->streaming = on;
> +       }
>
>  unlock:
>         mutex_unlock(&ov2659->lock);
> --
> 2.17.1
>