Re: [PATCH v10 6/8] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

[Ricardo Ribalda Delgado]

Hi Hans



On Mon, Oct 7, 2019 at 2:01 PM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote:
>
> On 10/7/19 1:35 PM, Ricardo Ribalda Delgado wrote:
> > New control to pass to userspace the width/height of a pixel. Which is
> > needed for calibration and lens selection.
> >
> > Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > Signed-off-by: Ricardo Ribalda Delgado <ribalda@xxxxxxxxxx>
> > ---
> >  Documentation/media/uapi/v4l/ext-ctrls-image-source.rst | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/Documentation/media/uapi/v4l/ext-ctrls-image-source.rst b/Documentation/media/uapi/v4l/ext-ctrls-image-source.rst
> > index 2c3ab5796d76..6388668855d0 100644
> > --- a/Documentation/media/uapi/v4l/ext-ctrls-image-source.rst
> > +++ b/Documentation/media/uapi/v4l/ext-ctrls-image-source.rst
> > @@ -55,3 +55,12 @@ Image Source Control IDs
> >
> >  ``V4L2_CID_TEST_PATTERN_GREENB (integer)``
> >      Test pattern green (next to blue) colour component.
> > +
> > +``V4L2_CID_UNIT_CELL_SIZE (struct)``
> > +    This control returns the unit cell size in nanometers. The struct
> > +    :c:type:`v4l2_area` provides the width and the height in separate
> > +    fields to take into consideration asymmetric pixels and/or hardware
> > +    binning.
>
> This still states that this control takes binning into account. I understood that
> we decided not to do that?
>

Good catch, seems that at some point I changed my mind :).

Will fix this doc.

Can I resend only this patch to avoid spamming the list?


> Regards,
>
>         Hans
>
> > +    The unit cell consists of the whole area of the pixel, sensitive and
> > +    non-sensitive.
> > +    This control is required for automatic calibration of sensors/cameras.
> >
>