Re: [PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each

From: kbuild test robot
Date: Thu Oct 10 2019 - 05:14:09 EST

Next message:
Previous message:
In reply to:
Next in thread:
Messages sorted by:
Hi Jules,

Thank you for the patch! Yet something
[auto build test ERROR on staging/staging-
url: .config.gz Description: application/gzipJason Wang: "Re: [PATCH V2 6/8] mdev: introduce virtio device and its device ops" Michal Kubecek: "Re: [PATCH net-next] genetlink: do not parse attributes for families with zero maxattr" Dan Carpenter: "Re: [PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each" Jules Irenge: "[PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each" href="date.html#02960">[ date ] [ thread ] [ subject ] [ author ] to improve: testing] ithub.com/0day-ci/linux/commits/Jules-Irenge/staging-qlge-Fix-multiple-assignments-warning-by-splitting-the-assignement-into-two-each/20191010-141520">https://github.com/0day-ci/linux/commits/Jules-Irenge/staging-qlge-Fix-multiple-assignments-warning-by-splitting-the-assignement-into-two-each/20191010-141520 (attached as .config) 7.4.0 to linux build tree following tag xxxxxx> >>): In function 'ql_get_serdes_regs': error: expected ';' before 'status' g(qdev, r> Ron Mercer 2010-01-15 134 Ron Mercer 2010-01-15 135 static int ql_get_serdes_regs(struct ql_adapter *qdev, Ron Mercer 2010-01-15 136 struct ql_mpi_coredump *mpi_coredump) Ron Mercer 2010-01-15 137 { Ron Mercer 2010-01-15 138 int status; Ron Mercer 2010-01-15 139 unsigned int xfi_direct_valid, xfi_indirect_valid, xaui_direct_valid; Ron Mercer 2010-01-15 140 unsigned int xaui_indirect_valid, i; Ron Mercer 2010-01-15 141 u32 *direct_ptr, temp; Ron Mercer 2010-01-15 142 u32 *indirect_ptr; Ron Mercer 2010-01-15 143 Jules Irenge 2019-10-09 144 xfi_indirect_valid = 0; Jules Irenge 2019-10-09 145 xfi_direct_valid = xfi_indirect_valid; Jules Irenge 2019-10-09 146 xaui_indirect_valid = 1; Jules Irenge 2019-10-09 147 xaui_direct_valid = xaui_indirect_valid Ron Mercer 2010-01-15 148 Ron Mercer 2010-01-15 149 /* The XAUI needs to be read out per port */ Ron Mercer 2010-01-15 @150 status = ql_read_other_func_serdes_reg(qdev, Ron Mercer 2010-01-15 151 XG_SERDES_XAUI_HSS_PCS_START, &temp); Ron Mercer 2010-01-15 152 if (status) Ron Mercer 2010-01-15 153 temp = XG_SERDES_ADDR_XAUI_PWR_DOWN; /qlge/qlge_dbg.c Gustavo A. R. Silva 2017-08-12 154 Ron Mercer 2010-01-15 155 if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) == Ron Mercer 2010-01-15 156 XG_SERDES_ADDR_XAUI_PWR_DOWN) Ron Mercer 2010-01-15 157 xaui_indirect_valid = 0; Ron Mercer 2010-01-15 158 /qlge/qlge_dbg.c Gustavo A. R. Silva 2017-08-12 159 status = ql_read_serdes_reg(qdev, XG_SERDES_XAUI_HSS_PCS_START, &temp); Ron Mercer 2010-01-15 160 Ron Mercer 2010-01-15 161 if (status) Ron Mercer 2010-01-15 162 temp = XG_SERDES_ADDR_XAUI_PWR_DOWN; Ron Mercer 2010-01-15 163 Ron Mercer 2010-01-15 164 if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) == Ron Mercer 2010-01-15 165 XG_SERDES_ADDR_XAUI_PWR_DOWN) Ron Mercer 2010-01-15 166 xaui_direct_valid = 0; Ron Mercer 2010-01-15 167 Ron Mercer 2010-01-15 168 /* Ron Mercer 2010-01-15 169 * XFI register is shared so only need to read one Ron Mercer 2010-01-15 170 * functions and then check the bits. Ron Mercer 2010-01-15 171 */ Ron Mercer 2010-01-15 172 status = ql_read_serdes_reg(qdev, XG_SERDES_ADDR_STS, &temp); Ron Mercer 2010-01-15 173 if (status) Ron Mercer 2010-01-15 174 temp = 0; Ron Mercer 2010-01-15 175 Ron Mercer 2010-01-15 176 if ((temp & XG_SERDES_ADDR_XFI1_PWR_UP) == Ron Mercer 2010-01-15 177 XG_SERDES_ADDR_XFI1_PWR_UP) { Ron Mercer 2010-01-15 178 /* now see if i'm NIC 1 or NIC 2 */ Ron Mercer 2010-01-15 179 if (qdev->func & 1) Ron Mercer 2010-01-15 180 /* I'm NIC 2, so the indirect (NIC1) xfi is up. */ Ron Mercer 2010-01-15 181 xfi_indirect_valid = 1; Ron Mercer 2010-01-15 182 else Ron Mercer 2010-01-15 183 xfi_direct_valid = 1; Ron Mercer 2010-01-15 184 } Ron Mercer 2010-01-15 185 if ((temp & XG_SERDES_ADDR_XFI2_PWR_UP) == Ron Mercer 2010-01-15 186 XG_SERDES_ADDR_XFI2_PWR_UP) { Ron Mercer 2010-01-15 187 /* now see if i'm NIC 1 or NIC 2 */ Ron Mercer 2010-01-15 188 if (qdev->func & 1) Ron Mercer 2010-01-15 189 /* I'm NIC 2, so the indirect (NIC1) xfi is up. */ Ron Mercer 2010-01-15 190 xfi_direct_valid = 1; Ron Mercer 2010-01-15 191 else Ron Mercer 2010-01-15 192 xfi_indirect_valid = 1; Ron Mercer 2010-01-15 193 } Ron Mercer 2010-01-15 194 Ron Mercer 2010-01-15 195 /* Get XAUI_AN register block. */ Ron Mercer 2010-01-15 196 if (qdev->func & 1) { Ron Mercer 2010-01-15 197 /* Function 2 is direct */ Ron Mercer 2010-01-15 198 direct_ptr = mpi_coredump->serdes2_xaui_an; Ron Mercer 2010-01-15 199 indirect_ptr = mpi_coredump->serdes_xaui_an; Ron Mercer 2010-01-15 200 } else { Ron Mercer 2010-01-15 201 /* Function 1 is direct */ Ron Mercer 2010-01-15 202 direct_ptr = mpi_coredump->serdes_xaui_an; Ron Mercer 2010-01-15 203 indirect_ptr = mpi_coredump->serdes2_xaui_an; Ron Mercer 2010-01-15 204 } Ron Mercer 2010-01-15 205 Ron Mercer 2010-01-15 206 for (i = 0; i <= 0x000000034; i += 4, direct_ptr++, indirect_ptr++) Ron Mercer 2010-01-15 207 ql_get_both_serdes(qdev, i, direct_ptr, indirect_ptr, Ron Mercer 2010-01-15 208 xaui_direct_valid, xaui_indirect_valid); Ron Mercer 2010-01-15 209 Ron Mercer 2010-01-15 210 /* Get XAUI_HSS_PCS register block. */ Ron Mercer 2010-01-15 211 if (qdev->func & 1) { Ron Mercer 2010-01-15 212 direct_ptr = Ron Mercer 2010-01-15 213 mpi_coredump->serdes2_xaui_hss_pcs; Ron Mercer 2010-01-15 214 indirect_ptr = Ron Mercer 2010-01-15 215 mpi_coredump->serdes_xaui_hss_pcs; Ron Mercer 2010-01-15 216 } else { Ron Mercer 2010-01-15 217 direct_ptr = Ron Mercer 2010-01-15 218 mpi_coredump->serdes_xaui_hss_pcs; Ron Mercer 2010-01-15 219 indirect_ptr = Ron Mercer 2010-01-15 220 mpi_coredump->serdes2_xaui_hss_pcs; Ron Mercer 2010-01-15 221 } Ron Mercer 2010-01-15 222 Ron Mercer 2010-01-15 223 for (i = 0x800; i <= 0x880; i += 4, direct_ptr++, indirect_ptr++) Ron Mercer 2010-01-15 224 ql_get_both_serdes(qdev, i, direct_ptr, indirect_ptr, Ron Mercer 2010-01-15 225 xaui_direct_valid, xaui_indirect_valid); Ron Mercer 2010-01-15 226 Ron Mercer 2010-01-15 227 /* Get XAUI_XFI_AN register block. */ Ron Mercer 2010-01-15 228 if (qdev->func & 1) { Ron Mercer 2010-01-15 229 direct_ptr = mpi_coredump->serdes2_xfi_an; Ron Mercer 2010-01-15 230 indirect_ptr = mpi_coredump->serdes_xfi_an; Ron Mercer 2010-01-15 231 } else { Ron Mercer 2010-01-15 232 direct_ptr = mpi_coredump->serdes_xfi_an; Ron Mercer 2010-01-15 233 indirect_ptr = mpi_coredump->serdes2_xfi_an; Ron Mercer 2010-01-15 234 } Ron Mercer 2010-01-15 235 Ron Mercer 2010-01-15 236 for (i = 0x1000; i <= 0x1034; i += 4, direct_ptr++, indirect_ptr++) Ron Mercer 2010-01-15 237 ql_get_both_serdes(qdev, i, direct_ptr, indirect_ptr, Ron Mercer 2010-01-15 238 xfi_direct_valid, xfi_indirect_valid); Ron Mercer 2010-01-15 239 Ron Mercer 2010-01-15 240 /* Get XAUI_XFI_TRAIN register block. */ Ron Mercer 2010-01-15 241 if (qdev->func & 1) { Ron Mercer 2010-01-15 242 direct_ptr = mpi_coredump->serdes2_xfi_train; Ron Mercer 2010-01-15 243 indirect_ptr = Ron Mercer 2010-01-15 244 mpi_coredump->serdes_xfi_train; Ron Mercer 2010-01-15 245 } else { Ron Mercer 2010-01-15 246 direct_ptr = mpi_coredump->serdes_xfi_train; Ron Mercer 2010-01-15 247 indirect_ptr = Ron Mercer 2010-01-15 248 mpi_coredump->serdes2_xfi_train; Ron Mercer 2010-01-15 249 } Ron Mercer 2010-01-15 250 Ron Mercer 2010-01-15 251 for (i = 0x1050; i <= 0x107c; i += 4, direct_ptr++, indirect_ptr++) Ron Mercer 2010-01-15 252 ql_get_both_serdes(qdev, i, direct_ptr, indirect_ptr, Ron Mercer 2010-01-15 253 xfi_direct_valid, xfi_indirect_valid); Ron Mercer 2010-01-15 254 Ron Mercer 2010-01-15 255 /* Get XAUI_XFI_HSS_PCS register block. */ Ron Mercer 2010-01-15 256 if (qdev->func & 1) { Ron Mercer 2010-01-15 257 direct_ptr = Ron Mercer 2010-01-15 258 mpi_coredump->serdes2_xfi_hss_pcs; Ron Mercer 2010-01-15 259 indirect_ptr = Ron Mercer 2010-01-15 260 mpi_coredump->serdes_xfi_hss_pcs; Ron Mercer 2010-01-15 261 } else { Ron Mercer 2010-01-15 262 direct_ptr = Ron Mercer 2010-01-15 263 mpi_coredump->serdes_xfi_hss_pcs; Ron Mercer 2010-01-15 264 indirect_ptr = Ron Mercer 2010-01-15 265 mpi_coredump->serdes2_xfi_hss_pcs; Ron Mercer 2010-01-15 266 } Ron Mercer 2010-01-15 267 Ron Mercer 2010-01-15 268 for (i = 0x1800; i <= 0x1838; i += 4, direct_ptr++, indirect_ptr++) Ron Mercer 2010-01-15 269 ql_get_both_serdes(qdev, i, direct_ptr, indirect_ptr, Ron Mercer 2010-01-15 270 xfi_direct_valid, xfi_indirect_valid); Ron Mercer 2010-01-15 271 Ron Mercer 2010-01-15 272 /* Get XAUI_XFI_HSS_TX register block. */ Ron Mercer 2010-01-15 273 if (qdev->func & 1) { Ron Mercer 2010-01-15 274 direct_ptr = Ron Mercer 2010-01-15 275 mpi_coredump->serdes2_xfi_hss_tx; Ron Mercer 2010-01-15 276 indirect_ptr = Ron Mercer 2010-01-15 277 mpi_coredump->serdes_xfi_hss_tx; Ron Mercer 2010-01-15 278 } else { Ron Mercer 2010-01-15 279 direct_ptr = mpi_coredump->serdes_xfi_hss_tx; Ron Mercer 2010-01-15 280 indirect_ptr = Ron Mercer 2010-01-15 281 mpi_coredump->serdes2_xfi_hss_tx; Ron Mercer 2010-01-15 282 } Ron Mercer 2010-01-15 283 for (i = 0x1c00; i <= 0x1c1f; i++, direct_ptr++, indirect_ptr++) Ron Mercer 2010-01-15 284 ql_get_both_serdes(qdev, i, direct_ptr, indirect_ptr, Ron Mercer 2010-01-15 285 xfi_direct_valid, xfi_indirect_valid); Ron Mercer 2010-01-15 286 Ron Mercer 2010-01-15 287 /* Get XAUI_XFI_HSS_RX register block. */ Ron Mercer 2010-01-15 288 if (qdev->func & 1) { Ron Mercer 2010-01-15 289 direct_ptr = Ron Mercer 2010-01-15 290 mpi_coredump->serdes2_xfi_hss_rx; Ron Mercer 2010-01-15 291 indirect_ptr = Ron Mercer 2010-01-15 292 mpi_coredump->serdes_xfi_hss_rx; Ron Mercer 2010-01-15 293 } else { Ron Mercer 2010-01-15 294 direct_ptr = mpi_coredump->serdes_xfi_hss_rx; Ron Mercer 2010-01-15 295 indirect_ptr = Ron Mercer 2010-01-15 296 mpi_coredump->serdes2_xfi_hss_rx; Ron Mercer 2010-01-15 297 } Ron Mercer 2010-01-15 298 Ron Mercer 2010-01-15 299 for (i = 0x1c40; i <= 0x1c5f; i++, direct_ptr++, indirect_ptr++) Ron Mercer 2010-01-15 300 ql_get_both_serdes(qdev, i, direct_ptr, indirect_ptr, Ron Mercer 2010-01-15 301 xfi_direct_valid, xfi_indirect_valid); Ron Mercer 2010-01-15 302 Ron Mercer 2010-01-15 303 Ron Mercer 2010-01-15 304 /* Get XAUI_XFI_HSS_PLL register block. */ Ron Mercer 2010-01-15 305 if (qdev->func & 1) { Ron Mercer 2010-01-15 306 direct_ptr = Ron Mercer 2010-01-15 307 mpi_coredump->serdes2_xfi_hss_pll; Ron Mercer 2010-01-15 308 indirect_ptr = Ron Mercer 2010-01-15 309 mpi_coredump->serdes_xfi_hss_pll; Ron Mercer 2010-01-15 310 } else { Ron Mercer 2010-01-15 311 direct_ptr = Ron Mercer 2010-01-15 312 mpi_coredump->serdes_xfi_hss_pll; Ron Mercer 2010-01-15 313 indirect_ptr = Ron Mercer 2010-01-15 314 mpi_coredump->serdes2_xfi_hss_pll; Ron Mercer 2010-01-15 315 } Ron Mercer 2010-01-15 316 for (i = 0x1e00; i <= 0x1e1f; i++, direct_ptr++, indirect_ptr++) Ron Mercer 2010-01-15 317 ql_get_both_serdes(qdev, i, direct_ptr, indirect_ptr, Ron Mercer 2010-01-15 318 xfi_direct_valid, xfi_indirect_valid); Ron Mercer 2010-01-15 319 return 0; Ron Mercer 2010-01-15 320 } Ron Mercer 2010-01-15 321 introduced by commit qlge: Add serdes reg blocks dump to firmware dump. xxxxx> xxxxxxxx> Open Source Technology Center org/pipermail/kbuild-all">https://lists.01.org/pipermail/kbuild-all Intel Corporation
- Next message: Jason Wang: "Re: [PATCH V2 6/8] mdev: introduce virtio device and its device ops"
- Previous message: Michal Kubecek: "Re: [PATCH net-next] genetlink: do not parse attributes for families with zero maxattr"
- In reply to: Dan Carpenter: "Re: [PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each"
- Next in thread: Jules Irenge: "[PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]