Re: [PATCH V2 6/8] mdev: introduce virtio device and its device ops

[Jason Wang]

On 2019/9/25 äå7:06, Alex Williamson wrote:
> On Tue, 24 Sep 2019 21:53:30 +0800
> Jason Wang<jasowang@xxxxxxxxxx>  wrote:
>
> > This patch implements basic support for mdev driver that supports
> > virtio transport for kernel virtio driver.
> >
> > Signed-off-by: Jason Wang<jasowang@xxxxxxxxxx>
> > ---
> >   include/linux/mdev.h        |   2 +
> >   include/linux/virtio_mdev.h | 145 ++++++++++++++++++++++++++++++++++++
> >   2 files changed, 147 insertions(+)
> >   create mode 100644 include/linux/virtio_mdev.h
> >
> > diff --git a/include/linux/mdev.h b/include/linux/mdev.h
> > index 3414307311f1..73ac27b3b868 100644
> > --- a/include/linux/mdev.h
> > +++ b/include/linux/mdev.h
> > @@ -126,6 +126,8 @@ struct mdev_device *mdev_from_dev(struct device *dev);
> >   
> >   enum {
> >   	MDEV_ID_VFIO = 1,
> > +	MDEV_ID_VIRTIO = 2,
> > +	MDEV_ID_VHOST = 3,
> MDEV_ID_VHOST isn't used yet here.  Also, given the strong
> interdependence between the class_id and the ops structure, we might
> wand to define them in the same place.  Thanks,
>
> Alex

Rethink about this, consider we may have more types of devices supported 
in the future, moving all device_ops to mdev.h seems unnecessary. I 
prefer to keep the device_ops into their own headers.

Thanks