Re: [PATCH 2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled

From: Andy Shevchenko
Date: Fri Oct 11 2019 - 05:05:14 EST


On Fri, Oct 11, 2019 at 11:48 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Fri, Oct 11, 2019 at 9:49 AM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> >
> > On Thu, Oct 10, 2019 at 11:37 PM Stuart Hayes <stuart.w.hayes@xxxxxxxxx> wrote:
> >
> > > Thank you for the feedback! An infinite loop is used several other places in
> > > this driver--this keeps the style similar. I can change it as you suggest,
> > > though, if that would be preferable to consistency.
> >
> > Better to start the change now. I'll look into the file and see how we
> > can improve the rest.
>
> I found only one infinite loop there, the other timeout loop is done
> as do {} while.
> I'll send a patch to refactor the infinite one.

https://lore.kernel.org/linux-pci/20191011090230.81080-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u

--
With Best Regards,
Andy Shevchenko