Re: [PATCH] writeback: Fix a warning while "make xmldocs"

From: Randy Dunlap
Date: Sun Oct 13 2019 - 02:17:38 EST


On 10/12/19 9:08 PM, Masanari Iida wrote:
> This patch fix following warning.
> ./fs/fs-writeback.c:918: warning: Excess function parameter
> 'nr_pages' description in 'cgroup_writeback_by_id'
>
> Signed-off-by: Masanari Iida <standby24x7@xxxxxxxxx>
> ---
> fs/fs-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index e88421d9a48d..8461a6322039 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -905,7 +905,7 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi,
> * cgroup_writeback_by_id - initiate cgroup writeback from bdi and memcg IDs
> * @bdi_id: target bdi id
> * @memcg_id: target memcg css id
> - * @nr_pages: number of pages to write, 0 for best-effort dirty flushing
> + * @nr: number of pages to write, 0 for best-effort dirty flushing
> * @reason: reason why some writeback work initiated
> * @done: target wb_completion
> *
>

https://lore.kernel.org/linux-fsdevel/756645ac-0ce8-d47e-d30a-04d9e4923a4f@xxxxxxxxxxxxx/

Andrew has already added this to his patches.

--
~Randy