Re: [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names

From: Lucas Stach
Date: Tue Oct 22 2019 - 12:05:05 EST


Am Montag, den 21.10.2019, 21:04 -0700 schrieb Andrey Smirnov:
> According to Documentation/devicetree/bindings/iio/accel/mma8452.txt,
> the correct interrupt-names are "INT1" and "INT2", so fix them
> accordingly.
>
> While at it, modify the node to only specify "INT2" since providing
> two interrupts is not necessary or useful (the driver will only use
> one).
>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> [andrew.smirnov@xxxxxxxxx modified the patch to drop INT1]
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>

Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>

> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: Chris Healy <cphealy@xxxxxxxxx>
> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
>
> Original patch from Fabio can be seen here:
>
> https://lore.kernel.org/linux-arm-kernel/20191010125300.2822-1-festevam@xxxxxxxxx/
>
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 8d46f7b2722b..a8c86e621b49 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -358,8 +358,8 @@
> compatible = "fsl,mma8451";
> reg = <0x1c>;
> interrupt-parent = <&gpio1>;
> - interrupt-names = "int1", "int2";
> - interrupts = <18 IRQ_TYPE_LEVEL_LOW>, <20 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "INT2";
> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
> };
>
> hpa2: amp@60 {
> @@ -849,7 +849,6 @@
> &iomuxc {
> pinctrl_accel: accelgrp {
> fsl,pins = <
> - MX6QDL_PAD_SD1_CMD__GPIO1_IO18 0x4001b000
> MX6QDL_PAD_SD1_CLK__GPIO1_IO20 0x4001b000
> >;
> };