Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver

From: Martin Kepplinger
Date: Fri Oct 25 2019 - 07:23:14 EST


Hi Daniel,

Quick note: You're missing a kref_init() in this version of the cooling driver.

Also, as already mentioned, set_freezable() doesn't seem to work without
supporting suspend/resume.

And since cpuidle got somewhat completely reworked in 5.4, could you create
a new, rebased version of this? Let me know in case I missed an earlier update.

thanks,

martin


---