Re: [EXT] [PATCH][next] net: aquantia: fix unintention integer overflow on left shift

From: Igor Russkikh
Date: Mon Oct 28 2019 - 05:45:41 EST

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Shifting the integer value 1 is evaluated using 32-bit
> arithmetic and then used in an expression that expects a 64-bit
> value, so there is potentially an integer overflow. Fix this
> by using the BIT_ULL macro to perform the shift and avoid the
> overflow.
> Addresses-Coverity: ("Unintentional integer overflow")
> Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Igor Russkikh <irusskikh@xxxxxxxxxxx>