Re: [PATCH][next] net: aquantia: fix unintention integer overflow on left shift

From: David Miller
Date: Tue Oct 29 2019 - 13:48:18 EST

From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri, 25 Oct 2019 12:58:11 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Shifting the integer value 1 is evaluated using 32-bit
> arithmetic and then used in an expression that expects a 64-bit
> value, so there is potentially an integer overflow. Fix this
> by using the BIT_ULL macro to perform the shift and avoid the
> overflow.
> Addresses-Coverity: ("Unintentional integer overflow")
> Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>