Re: [PATCH][V2] ata: pata_artop: make arrays static const, makes object smaller

[Bartlomiej Zolnierkiewicz]

On 10/6/19 4:29 PM, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> Don't populate the const arrays on the stack but instead make them
> static. Makes the object code smaller by 292 bytes.
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    6988	   3132	    128	  10248	   2808	drivers/ata/pata_artop.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    6536	   3292	    128	   9956	   26e4	drivers/ata/pata_artop.o
> 
> (gcc version 9.2.1, amd64)
> 
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> 
> V2: fix up commit message
> 
> ---
>  drivers/ata/pata_artop.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
> index 3aa006c5ed0c..6bd2228bb6ff 100644
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
> @@ -100,7 +100,7 @@ static void artop6210_load_piomode(struct ata_port *ap, struct ata_device *adev,
>  {
>  	struct pci_dev *pdev	= to_pci_dev(ap->host->dev);
>  	int dn = adev->devno + 2 * ap->port_no;
> -	const u16 timing[2][5] = {
> +	static const u16 timing[2][5] = {
>  		{ 0x0000, 0x000A, 0x0008, 0x0303, 0x0301 },
>  		{ 0x0700, 0x070A, 0x0708, 0x0403, 0x0401 }
>  
> @@ -154,7 +154,7 @@ static void artop6260_load_piomode (struct ata_port *ap, struct ata_device *adev
>  {
>  	struct pci_dev *pdev	= to_pci_dev(ap->host->dev);
>  	int dn = adev->devno + 2 * ap->port_no;
> -	const u8 timing[2][5] = {
> +	static const u8 timing[2][5] = {
>  		{ 0x00, 0x0A, 0x08, 0x33, 0x31 },
>  		{ 0x70, 0x7A, 0x78, 0x43, 0x41 }
>