Re: [PATCH][V2] ata: pata_artop: make arrays static const, makes object smaller

From: Jens Axboe
Date: Fri Nov 08 2019 - 09:27:04 EST


On 10/6/19 8:29 AM, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate the const arrays on the stack but instead make them
> static. Makes the object code smaller by 292 bytes.
>
> Before:
> text data bss dec hex filename
> 6988 3132 128 10248 2808 drivers/ata/pata_artop.o
>
> After:
> text data bss dec hex filename
> 6536 3292 128 9956 26e4 drivers/ata/pata_artop.o
>
> (gcc version 9.2.1, amd64)

Applied, thanks.

--
Jens Axboe