Re: [PATCH v11 1/2] fork: extend clone3() to support setting a PID

[Dmitry Safonov]

On 11/15/19 12:36 PM, Adrian Reber wrote:
[..]
> Signed-off-by: Adrian Reber <areber@xxxxxxxxxx>
> Reviewed-by: Christian Brauner <christian.brauner@xxxxxxxxxx>

Reviewed-by: Dmitry Safonov <0x7f454c46@xxxxxxxxx>

[though, I have 2 minor nits below]

[..]
> + * @set_tid:      Pointer to an array of type *pid_t. The size
> + *                of the array is defined using @set_tid_size.
> + *                This array is used select PIDs/TIDs for newly

/is used select/is used to select/s


[..]
> +	size_t set_tid_size;
> +	__aligned_u64 set_tid_size;

[..]
> +		.set_tid_size	= args.set_tid_size,

Is sizeof(size_t) == 32 on native 32-bit platforms?
Maybe `args.set_tid_size` should be checked?

Thanks,
          Dmitry