Re: [PATCH v11 1/2] fork: extend clone3() to support setting a PID
From: Dmitry Safonov
Date: Fri Nov 15 2019 - 12:02:27 EST
On 11/15/19 4:54 PM, Dmitry Safonov wrote:
> [..]
>> + size_t set_tid_size;
>> + __aligned_u64 set_tid_size;
>
> [..]
>> + .set_tid_size = args.set_tid_size,
>
> Is sizeof(size_t) == 32 on native 32-bit platforms?
> Maybe `args.set_tid_size` should be checked?
Nevermind, I missed that
+ if (unlikely(args.set_tid_size > MAX_PID_NS_LEVEL))
+ return -EINVAL;
is checked for `args' - it should be good enough.
Thanks,
Dmitry