Re: [PATCH v2] dell-smm-hwmon: Add support for disabling automatic BIOS fan control

[Pali RohÃr]

On Saturday 16 November 2019 07:53:10 Guenter Roeck wrote:
> On 11/16/19 6:58 AM, Pali RohÃr wrote:
> > On Saturday 16 November 2019 15:06:49 Giovanni Mascellani wrote:
> > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > index 4212d022d253..67b8c0adede8 100644
> > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > @@ -68,6 +68,8 @@ static uint i8k_pwm_mult;
> > >   static uint i8k_fan_max = I8K_FAN_HIGH;
> > >   static bool disallow_fan_type_call;
> > >   static bool disallow_fan_support;
> > > +static unsigned int smm_manual_fan;
> > > +static unsigned int smm_auto_fan;
> 
> The "smm_" prefix does not have any value here.

These variables store SMM command numbers and seems that in this patch
they were converted from macros "#define I8K_SMM_MANUAL_FAN	0x34a3"

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: PGP signature