Re: [PATCH v2] dell-smm-hwmon: Add support for disabling automatic BIOS fan control

[Giovanni Mascellani]

Hi,

Il 16/11/19 16:53, Guenter Roeck ha scritto:
>>> Â @@ -1135,12 +1183,48 @@ static struct dmi_system_id
>>> i8k_blacklist_fan_support_dmi_table[] __initdata = {
>>> ÂÂÂÂÂ { }
>>> Â };
>>> Â +struct i8k_manual_fan_data {
>>> +ÂÂÂ unsigned int smm_manual_fan;
>>> +ÂÂÂ unsigned int smm_auto_fan;
>>> +};
>>
>> Just cosmetic suggestion: As this structure contains data for both
>> manual and automatic mode I would not use "manual" in name. But e.g.
>> something like "i8k_bios_fan_control_data"...
>>
> Or i8k_fan_control_data. Also, "manual" and "auto" for the variable
> names would be sufficient.

"auto" is a keyword, so I cannot use it. I've left "manual_fan" and
"auto_fan" therefore.

Thanks and ack for all the other changes. I'll submit the updated patch
shortly.

Giovanni.
-- 
Giovanni Mascellani <g.mascellani@xxxxxxxxx>
Postdoc researcher - Università Libre de Bruxelles

Attachment: signature.asc
Description: OpenPGP digital signature