Re: [PATCH 06/12] drivers/soc: Add Aspeed XDMA Engine Driver

From: Andrew Jeffery
Date: Sun Nov 24 2019 - 18:59:51 EST



> > +static int aspeed_xdma_remove(struct platform_device *pdev)
> > +{
> > + struct aspeed_xdma *ctx = platform_get_drvdata(pdev);
> > +
> > + gen_pool_free(ctx->vga_pool, (unsigned long)ctx->cmdq_vga_virt,
> > + XDMA_CMDQ_SIZE);
>
> You've used devm_gen_pool_create(), so no need to explicitly free it.

Sorry, disregard that, brain-fart.

Andrew