RE: [PATCH 1/2] can: xilinx_can: skip error message on deferred probe

[Appana Durga Kedareswara Rao]

Hi,

> -----Original Message-----
> From: Srinivas Neeli <srinivas.neeli@xxxxxxxxxx>
> Sent: Wednesday, November 20, 2019 5:41 PM
> To: wg@xxxxxxxxxxxxxx; mkl@xxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx;
> Michal Simek <michals@xxxxxxxxxx>; Appana Durga Kedareswara Rao
> <appanad@xxxxxxxxxx>
> Cc: linux-can@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; git
> <git@xxxxxxxxxx>; Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>;
> Venkatesh Yadav Abbarapu <VABBARAP@xxxxxxxxxx>; Srinivas Neeli
> <sneeli@xxxxxxxxxx>
> Subject: [PATCH 1/2] can: xilinx_can: skip error message on deferred probe
> 
> From: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@xxxxxxxxxx>
> 
> When can clock is provided from the clock wizard, clock wizard driver may
> not be available when can driver probes resulting to the error message "bus
> clock not found error".
> 
> As this error message is not very useful to the end user, skip printing in the
> case of deferred probe.
> 
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@xxxxxxxxxx>
> Signed-off-by: Srinivas Neeli <srinivas.neeli@xxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>

@Srinivas Neeli: Please send v2 with improved commit message as Marc suggested, feel free to add 
Reviewed-by: Appana Durga Kedareswara Rao <appana.durga.rao@xxxxxxxxxx> in v2. 

Regards,
Kedar.
> ---
>  drivers/net/can/xilinx_can.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index
> 4a96e2dd7d77..c5f05b994435 100644
> --- a/drivers/net/can/xilinx_can.c
> +++ b/drivers/net/can/xilinx_can.c
> @@ -1772,7 +1772,8 @@ static int xcan_probe(struct platform_device
> *pdev)
> 
>  	priv->bus_clk = devm_clk_get(&pdev->dev, devtype->bus_clk_name);
>  	if (IS_ERR(priv->bus_clk)) {
> -		dev_err(&pdev->dev, "bus clock not found\n");
> +		if (PTR_ERR(priv->bus_clk) != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "bus clock not found\n");
>  		ret = PTR_ERR(priv->bus_clk);
>  		goto err_free;
>  	}
> --
> 2.7.4