Re: [PATCH v5 10/13] exfat: add nls operations

[Markus Elfring]

â
> +++ b/fs/exfat/nls.c
â
> +static int exfat_load_upcase_table(struct super_block *sb,
> +		sector_t sector, unsigned long long num_sectors,
> +		unsigned int utbl_checksum)
> +{
â
> +	unsigned int i, index = 0, checksum = 0;
â
> +			checksum = ((checksum & 1) ? 0x80000000 : 0) +
> +				(checksum >> 1) +
> +				*(((unsigned char *)bh->b_data) + (i + 1));
â
> +	if (index >= 0xFFFF && utbl_checksum == checksum)
> +		return 0;

* Can it be that a type other than âintâ would be more portable
  for the desired data processing at these source code places?

* How do you think about to use more meaningful identifiers for
  two of the shown literals?

Regards,
Markus