Re: [PATCH] wil6210: fix break that is never reached because of zero'ing of a retry counter

From: Kalle Valo
Date: Mon Nov 25 2019 - 07:15:01 EST


Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> There is a check on the retry counter invalid_buf_id_retry that is always
> false because invalid_buf_id_retry is initialized to zero on each iteration
> of a while-loop. Fix this by initializing the retry counter before the
> while-loop starts.
>
> Addresses-Coverity: ("Logically dead code")
> Fixes: b4a967b7d0f5 ("wil6210: reset buff id in status message after completion")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> Reviewed-by: Maya Erez <merez@xxxxxxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

5b1413f00b5b wil6210: fix break that is never reached because of zero'ing of a retry counter

--
https://patchwork.kernel.org/patch/11246193/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches