Re: [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'

[Alex Deucher]

On Mon, Nov 25, 2019 at 10:00 AM YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
>
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> index 2dd5fee..468f5e6 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> @@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
>         struct psp_context *psp = hdcp->config.psp.handle;
>         struct ta_hdcp_shared_memory *hdcp_cmd;
>         struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> -       struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
>         struct mod_hdcp_display *display = get_first_added_display(hdcp);
>
>         hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
>         memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
>         msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> -       msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
>         hdcp2_message_init(hdcp, msg_in);
>
> @@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
>         struct psp_context *psp = hdcp->config.psp.handle;
>         struct ta_hdcp_shared_memory *hdcp_cmd;
>         struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> -       struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
>         uint8_t i;
>
>         hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
>         memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
>         msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> -       msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
>         hdcp2_message_init(hdcp, msg_in);
>
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx