Re: [PATCH v5 03/26] dt-bindings: leds: Add LED_FUNCTION definitions

[Pavel Machek]

On Fri 2019-11-15 14:01:50, Geert Uytterhoeven wrote:
> Hi Jacek,
> 
> On Sun, Jun 9, 2019 at 9:09 PM Jacek Anaszewski
> <jacek.anaszewski@xxxxxxxxx> wrote:
> > Add initial set of common LED function definitions.
> >
> > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
> 
> > --- a/include/dt-bindings/leds/common.h
> > +++ b/include/dt-bindings/leds/common.h
> > @@ -30,4 +31,45 @@
> >  #define LED_COLOR_ID_IR                7
> >  #define LED_COLOR_ID_MAX       8
> >
> > +/* Standard LED functions */
> > +#define LED_FUNCTION_ACTIVITY "activity"
> 
> What's the appropriate function for "general purpose" or "user" LEDs on
> development boards, where the LEDs don't have fixed functions, unlike
> on real products?
> Perhaps just LED_FUNCTION_INDICATOR?

I'd prefer such LEDs to not exist :-).

> I noticed your very initial submission defined LED_FUNCTION_USER "user".
> I couldn't find an explanation for the rationale behind its removal in later
> revisions, or any discussion asking for that.

There are "user" leds even on non-development boads... one is labeled
"scroll lock".

For the development board, I'd actually prefer to assign some
reasonable functions. If vendor BSP uses the LEDs for disk and network
indicators (for example) I'd just mark it as a disk and network
LEDs...

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature