Re: [PATCH 1/8] add header file for kelvin to/from Celsius conversion helpers

[Andy Shevchenko]

On Mon, Nov 25, 2019 at 4:30 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
> 2019å11æ24æ(æ) 23:57 Andy Shevchenko <andy.shevchenko@xxxxxxxxx>:
> > On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:

> > >  include/linux/thermal.h     |  1 +

> > > --- a/include/linux/thermal.h
> > > +++ b/include/linux/thermal.h
> > > @@ -14,6 +14,7 @@
> > >  #include <linux/idr.h>
> > >  #include <linux/device.h>
> > >  #include <linux/sysfs.h>
> > > +#include <linux/temperature.h>
> > >  #include <linux/workqueue.h>
> > >  #include <uapi/linux/thermal.h>
> >
> > I don't see any users of it. Why did you include?
>
> The rest of this patch series starts using it.
>
> I decided to include <linux/temperature.h> from <linux/thermal.h> because
> the existing <linux/thermal.h> provides the conversion helpers.
>
> However, not all of the thermal drivers require these conversion helpers,
> so we can change to include <linux/temperature.h> from each thermal driver
> instead of including it from <linux/thermal.h>.
>
> Which way do you prefer?

I think users should include new header explicitly.

-- 
With Best Regards,
Andy Shevchenko