RE: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers

[Anson Huang]

> Subject: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers
> 
> Gratuitous NULL initializers rarely help and often prevent compiler from
> warning about using uninitialized variable. Let's remove them.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Reviewed-by: Anson Huang <Anson.Huang@xxxxxxx>

> ---
>  drivers/input/keyboard/snvs_pwrkey.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/snvs_pwrkey.c
> b/drivers/input/keyboard/snvs_pwrkey.c
> index fd6f244f403d..2f5e3ab5ed63 100644
> --- a/drivers/input/keyboard/snvs_pwrkey.c
> +++ b/drivers/input/keyboard/snvs_pwrkey.c
> @@ -108,8 +108,8 @@ static void imx_snvs_pwrkey_act(void *pdata)
> 
>  static int imx_snvs_pwrkey_probe(struct platform_device *pdev)  {
> -	struct pwrkey_drv_data *pdata = NULL;
> -	struct input_dev *input = NULL;
> +	struct pwrkey_drv_data *pdata;
> +	struct input_dev *input;
>  	struct device_node *np;
>  	int error;
>  	u32 vid;
> --
> 2.24.0.432.g9d3f5f5b63-goog
> 
> 
> --
> Dmitry