Re: [PATCH] Input: Fix memory leak in psxpad_spi_probe

From: Greg Kroah-Hartman
Date: Tue Nov 26 2019 - 04:34:41 EST


On Fri, Nov 22, 2019 at 11:02:08AM -0800, Dmitry Torokhov wrote:
> Hi Navid,
>
> On Thu, Nov 21, 2019 at 02:01:11PM -0600, Navid Emamdoost wrote:
> > In the implementation of psxpad_spi_probe() the allocated memory for
> > pdev is leaked if psxpad_spi_init_ff() or input_register_polled_device()
> > fail. The solution is using device managed allocation, like the one used
> > for pad. Perform the allocation using
> > devm_input_allocate_polled_device().
> >
> > Fixes: 8be193c7b1f4 ("Input: add support for PlayStation 1/2 joypads connected via SPI")
> > Signed-off-by: Navid Emamdoost <navid.emamdoost@xxxxxxxxx>
>
> This is fixed in the current version of the driver, but you can send it
> to stable@xxxxxxxxxxxxx with my

Was it fixed by any specific patch, or just a side-affect of some other
larger change?

thanks,

greg k-h