Re: [PATCH v6 1/2] perf: support multiple debug options separated by ','

From: Changbin Du
Date: Tue Nov 26 2019 - 09:34:15 EST


On Tue, Nov 26, 2019 at 10:45:08AM +0100, Jiri Olsa wrote:
> On Mon, Nov 25, 2019 at 11:14:45PM +0800, Changbin Du wrote:
> > This patch adds support for multiple debug options separated by ',' and
> > non-int values.
> > --debug verbose=2,stderr
> >
> > Signed-off-by: Changbin Du <changbin.du@xxxxxxxxx>
> > ---
> > tools/perf/Documentation/perf.txt | 13 +++--
> > tools/perf/util/debug.c | 89 ++++++++++++++++---------------
> > 2 files changed, 53 insertions(+), 49 deletions(-)
> >
> > diff --git a/tools/perf/Documentation/perf.txt b/tools/perf/Documentation/perf.txt
> > index 3f37ded13f8c..fd8d790f68a7 100644
> > --- a/tools/perf/Documentation/perf.txt
> > +++ b/tools/perf/Documentation/perf.txt
> > @@ -19,13 +19,12 @@ OPTIONS
> > --debug verbose=2 # sets verbose = 2
> >
> > List of debug variables allowed to set:
> > - verbose - general debug messages
> > - ordered-events - ordered events object debug messages
> > - data-convert - data convert command debug messages
> > - stderr - write debug output (option -v) to stderr
> > - in browser mode
> > - perf-event-open - Print perf_event_open() arguments and
> > - return value
> > + verbose=level - general debug messages
> > + ordered-events=level - ordered events object debug messages
> > + data-convert=level - data convert command debug messages
> > + stderr - write debug output (option -v) to stderr
> > + perf-event-open - Print perf_event_open() arguments and
> > + return value in browser mode
>
> it's just the list and the doc says user can use values
> there, so no need for the '=level' there
>
> also we allow this:
> perf --debug stderr=9 record ls
>
> so I thinks we should keep it general in documentation,
> eventhough it will always mean just stderr=true for any
> value
>
I changed them as below. For stderr and perf_event_open, the value is ignored
even it is given.

--debug::
Setup debug variable (see list below). The range of 'level' value
is (0, 10). Use like:
--debug verbose # sets verbose = 1
--debug verbose=2,file=~/perf.log
# sets verbose = 2 and save log to file

List of debug variables allowed to set:
verbose[=level] - general debug messages
ordered-events[=level]- ordered events object debug messages
data-convert[=level] - data convert command debug messages
stderr - write debug output (option -v) to stderr
in browser mode
perf-event-open - Print perf_event_open() arguments and
return value

> jirka
>

--
Cheers,
Changbin Du