Re: [PATCH] pinctrl: samsung: modularize samsung pinctrl driver

[Krzysztof Kozlowski]

On Tue, 26 Nov 2019 at 14:09, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Tue, 26 Nov 2019 at 09:14, Hyunki Koo <hyunki00.koo@xxxxxxxxxxx> wrote:
> >
> > On Thu, 21 Nov 2019 at 16:38, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > > Hi,
> > >
> > > Thanks for the patch. Few comments below:
> > >
> > > On Thu, 21 Nov 2019 at 15:26, êíê <hyunki00.koo@xxxxxxxxxxx> wrote:
> > >>
> > >> Enable samsung pinctrl driver to be compiled as modules.
> > >
> > > Why? What's the benefit? Are platforms capable of such boot? Pinctrl is needed early - even before mounting rootfs...
> > > What about module unloading? Is it reasonable?
> > > Please answer to all this also in commit message.
> > >
> >
> > Sorry to late and Thank you for your comment, I would like to apply GKI on the pinctrl driver
> > So I would like to cut off dependency from ARCH_EXYNOS.
>
> This is driver for Exynos and S3C so why cutting off the dependency? I
> mean, wait, it is a driver for Exynos so it cannot work on other
> boards...

One more thought about Generic Kernel Image for Android. It implies
that vendor stuff will be in modules... but only for out-of-tree code.
The Exynos pinctrl driver is already in mainline so moving it into
module is not necessary.

As for dependency on ARCH_EXYNOS - I do not get why this is a problem.
ARCH_EXYNOS is multiplatform ready so you can boot multi_v7... What
would be the benefit of removing this dependency?

Best regards,
Krzysztof