Re: [PATCH] cpu: microcode: Add comma to 0

[Ingo Molnar]

* Jules Irenge <jbi.octave@xxxxxxxxx> wrote:

> Add ","  after 0
> Because memory for the struct is being cleared
> and elements after "," are missing on purpose
>  as they are being cleared to
> 
> Recommended by Boris Petkov
> 
> Signed-off-by: Jules Irenge <jbi.octave@xxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/microcode/amd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
> index a0e52bd00ecc..04ee649f4acb 100644
> --- a/arch/x86/kernel/cpu/microcode/amd.c
> +++ b/arch/x86/kernel/cpu/microcode/amd.c
> @@ -418,7 +418,7 @@ static int __apply_microcode_amd(struct microcode_amd *mc)
>  static bool
>  apply_microcode_early_amd(u32 cpuid_1_eax, void *ucode, size_t size, bool save_patch)
>  {
> -	struct cont_desc desc = { 0 };
> +	struct cont_desc desc = { 0, };

This is 100% unnecessary - " = { }" is enough of a structure initializer.

Thanks,

	Ingo