[PATCH] perf c2c: fix '-e list'
From: Ian Rogers
Date: Wed Nov 27 2019 - 02:35:00 EST
When the event is passed as list, the default events should be listed as
per 'perf mem record -e list'. Previous behavior is:
$ perf c2c record -e list
failed: event 'list' not found, use '-e list' to get list of available events
Usage: perf c2c record [<options>] [<command>]
or: perf c2c record [<options>] -- <command> [<options>]
-e, --event <event> event selector. Use 'perf mem record -e list' to list available events
New behavior:
$ perf c2c record -e list
ldlat-loads : available
ldlat-stores : available
Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
---
tools/perf/builtin-c2c.c | 20 ++++++++++++++++++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index e69f44941aad..dd69cd218e4c 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -2872,10 +2872,26 @@ static int perf_c2c__report(int argc, const char **argv)
static int parse_record_events(const struct option *opt,
const char *str, int unset __maybe_unused)
{
+ int j;
bool *event_set = (bool *) opt->value;
- *event_set = true;
- return perf_mem_events__parse(str);
+ if (strcmp(str, "list")) {
+ *event_set = true;
+ if (!perf_mem_events__parse(str))
+ return 0;
+
+ exit(-1);
+ }
+ for (j = 0; j < PERF_MEM_EVENTS__MAX; j++) {
+ struct perf_mem_event *e = &perf_mem_events[j];
+
+ fprintf(stderr, "%-13s%-*s%s\n",
+ e->tag,
+ verbose > 0 ? 25 : 0,
+ verbose > 0 ? perf_mem_events__name(j) : "",
+ e->supported ? ": available" : "");
+ }
+ exit(0);
}
--
2.24.0.393.g34dc348eaf-goog