Re: [PATCH net] net: wireless: intel: iwlwifi: fix GRO_NORMAL packet stalling

From: Alexander Lobakin
Date: Wed Nov 27 2019 - 06:45:13 EST


Nicholas Johnson wrote 27.11.2019 14:16:
On Wed, Nov 27, 2019 at 01:29:03PM +0300, Alexander Lobakin wrote:
Nicholas Johnson wrote 27.11.2019 13:23:
> Hi,

Hi Nicholas,

> Sorry for top down reply, stuck with my phone. If it replies HTML
> then I am so done with Outlook client.

I am very sorry to everybody for the improper reply. It looks like it
was HTML as vger.kernel.org told me I was spam. If anybody knows a good
email client for kernel development for Android then I am all ears.

I went home early and I have my computer(s) now.

>
> Does my Reported-by tag apply here?
>
> As the reporter, should I check to see that it indeed solves the
> issue on the original hardware setup? I can do this within two hours
> and give Tested-by then.

Oops, I'm sorry I forgot to mention you in the commit message. Let's
see what Dave will say, I have no problems with waiting for your test
results and publishing v2.

All good. :)

I tested the the patch and it works fine. Great work, the first
hypothesis as to what the problem was is correct. It now connects to
wireless networks without any hassles.

Reported-by: Nicholas Johnson <nicholas.johnson-opensource@xxxxxxxxxxxxxx>
Tested-by: Nicholas Johnson <nicholas.johnson-opensource@xxxxxxxxxxxxxx>

Oh, much thanks for testing this out! I think this one will hit netdev
fixes tree soon.

I do not understand the networking subsystem well enough to give
Reviewed-by, yet. Hopefully in time.

I'm sure you will :)

Thanks to everybody for handling my report.


> Thanks
>
> Regards,
>
> Nicholas

Regards,
á á á á á á

Regards,
Nicholas

Regards,
á á á á á á