Re: [PATCHv2 6/6] ASoC: da7213: Add default clock handling

From: Mark Brown
Date: Wed Nov 27 2019 - 07:33:22 EST


On Wed, Nov 27, 2019 at 11:32:54AM +0000, Adam Thomson wrote:

> As I said it's a small thing and requires a specific use-case to occur, but
> having the PLL configured twice for the very first stream in that scenario
> seems messy. Regarding the SYSCLK approach you mention, I'm not clear how that
> would work so I'm obviously missing something. If we had some init stage
> indication though that auto PLL was required then we're golden.

There's a bunch of other drivers using the SYSCLK thing, when you call
set_sysclk() they provide a different SYSCLK number if they want to use
manual mode. If there's a concern about drivers doing stuff on init you
could always ask them to set the PLL during init, even if only briefly.

Attachment: signature.asc
Description: PGP signature