Re: [PATCH] brcmsmac: Remove always false 'channel < 0' statement

[Kalle Valo]

Austin Kim <austindh.kim@xxxxxxxxx> writes:

> 2019ë 11ì 27ì (ì) ìí 7:48, Sergei Shtylyov
> <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>ëì ìì:
>>
>> On 27.11.2019 8:43, Austin Kim wrote:
>>
>> > As 'channel' is declared as u16, the following statement is always false.
>> >     channel < 0
>> >
>> > So we can remove unnecessary 'always false' statement.
>>
>>     It's an expression, not a statement.
>>
>
> According to below link, it is okay to use 'statement' in above case.
> https://en.wikipedia.org/wiki/Statement_(computer_science)

I don't have time to start arguing about this, and I'm no C language
lawyer either, but all I say is that I agree with Sergei here.

> Why don't you show your opition about patch rather than commit message?

But this comment is not ok. Patch review (including commit logs) is the
core principle of upstream development so you need to have an open mind
for all comments, even the ones you don't like.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches