Re: [PATCH] KVM: Add separate helper for putting borrowed reference to kvm

[Paolo Bonzini]

On 26/11/19 18:53, Leonardo Bras wrote:
> 
> I agree an use-after-free more problem than a memory leak, but I think
> that there is a way to solve this without leaking the memory also.
> 
> One option would be reordering the kvm_put_kvm(), like in this patch:
> https://lkml.org/lkml/2019/11/26/517

It's a tradeoff between "fix one bug" and "mitigate all bugs of that
class", both are good things to do.  Reordering the kvm_put_kvm() fixes
the bug.  kvm_put_kvm_no_destroy() makes all bugs of that kind less
severe, but it doesn't try to fix them.

Paolo

Attachment: signature.asc
Description: OpenPGP digital signature