Re: [PATCH 2/3] net: macb: add support for C45 MDIO read/write

From: Nicolas.Ferre
Date: Wed Nov 27 2019 - 13:32:00 EST


On 26/11/2019 at 15:37, Andrew Lunn wrote:
> On Tue, Nov 26, 2019 at 09:09:49AM +0000, Milind Parab wrote:
>> This patch modify MDIO read/write functions to support
>> communication with C45 PHY.
>
> I think i've asked this before, at least once, but you have not added
> it to the commit messages. Do all generations of the macb support C45?

For what I can tell from the different IP revisions that we implemented
throughout the years in Atmel then Microchip products (back to
at91rm9200 and at91sam9263), it seems yes.

The "PHY Maintenance Register" "MACB_MAN_*" was always present with the
same bits 32-28 layout (with somehow different names).

But definitively we would need to hear that from Cadence itself which
would be far better.

[..]

Best regards,
--
Nicolas Ferre