Re: [PATCH v6 0/4] Bluetooth: hci_bcm: Additional changes for BCM4354 support

From: Abhishek Pandit-Subedi
Date: Wed Nov 27 2019 - 17:15:06 EST


On Tue, Nov 26, 2019 at 9:37 PM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Abhishek,
>
> > The series looks good to me.
>
> you also tested it on your hardware?
>
> Regards
>
> Marcel
>

I have tested it on my hardware and it looks good now.

Only problem is it looks like the documentation is slightly wrong:

+ brcm,bt-pcm-int-params = [1 2 0 1 1];
should be
+ brcm,bt-pcm-int-params = [01 02 00 01 01];
or
+ brcm,bt-pcm-int-params = /bits/ 8 <1 2 0 1 1>;

Thanks
Abhishek