Re: [PATCH 4/4] checkpatch: Drop pr_warning check

[Joe Perches]

On Thu, 2019-11-28 at 08:47 +0800, Kefeng Wang wrote:
> All pr_warning are removed from kernel, let's cleanup pr_warning
> check in checkpatch.
> 
> Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx>
> Cc: Joe Perches <joe@xxxxxxxxxxx>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>

Assuming the other bits go in:

Acked-by: Joe Perches <joe@xxxxxxxxxxx>

> ---
>  scripts/checkpatch.pl | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 64890be3c8fd..447c0050eec0 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4113,15 +4113,6 @@ sub process {
>  			     "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(...  to printk(KERN_$orig ...\n" . $herecurr);
>  		}
>  
> -		if ($line =~ /\bpr_warning\s*\(/) {
> -			if (WARN("PREFER_PR_LEVEL",
> -				 "Prefer pr_warn(... to pr_warning(...\n" . $herecurr) &&
> -			    $fix) {
> -				$fixed[$fixlinenr] =~
> -				    s/\bpr_warning\b/pr_warn/;
> -			}
> -		}
> -
>  		if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
>  			my $orig = $1;
>  			my $level = lc($orig);