Re: [PATCH v4] tpm: Add tpm_version_major sysfs file

[Jerry Snitselaar]

On Wed Oct 30 19, Jerry Snitselaar wrote:
> Easily determining what TCG version a tpm device implements
> has been a pain point for userspace for a long time, so
> add a sysfs file to report the TCG major version of a tpm device.
>
> Also add an entry to Documentation/ABI/stable/sysfs-class-tpm
> describing the new file.
>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> Cc: Mimi Zohar <zohar@xxxxxxxxxxxxx>
> Cc: Peter Huewe <peterhuewe@xxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxx>
> Cc: linux-integrity@xxxxxxxxxxxxxxx
> Signed-off-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>
> ---
> v4: - Change file name to tpm_version_major
>    - Actually display just the major version.
>    - change structs to tpm1_* & tpm2_*
>      instead of tpm12_* tpm20_*.
> v3: - Change file name to version_major.
> v2: - Fix TCG usage in commit message.
>    - Add entry to sysfs-class-tpm in Documentation/ABI/stable
>
> Documentation/ABI/stable/sysfs-class-tpm | 11 ++++++++
> drivers/char/tpm/tpm-sysfs.c             | 34 +++++++++++++++++++-----
> 2 files changed, 38 insertions(+), 7 deletions(-)

Anyone else have feedback?