Re: [PATCH 3/4] printk: Drop pr_warning definition
From: kbuild test robot
Date: Thu Nov 28 2019 - 02:15:17 EST
Hi Kefeng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on wq/for-next]
[cannot apply to pmladek/for-next v5.4 next-20191127]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kefeng-Wang/part2-kill-pr_warning-from-kernel/20191128-085343
base: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/platform/x86/eeepc-laptop.c: In function 'eeepc_rfkill_hotplug':
>> drivers/platform/x86/eeepc-laptop.c:581:3: error: implicit declaration of function 'pr_warning'; did you mean 'acpi_warning'? [-Werror=implicit-function-declaration]
pr_warning("Unable to find port\n");
^~~~~~~~~~
acpi_warning
cc1: some warnings being treated as errors
--
drivers/video/console/vgacon.c: In function 'text_mode':
>> drivers/video/console/vgacon.c:116:2: error: implicit declaration of function 'pr_warning'; did you mean 'pr_warn'? [-Werror=implicit-function-declaration]
pr_warning("You have booted with nomodeset. This means your GPU drivers are DISABLED\n");
^~~~~~~~~~
pr_warn
cc1: some warnings being treated as errors
--
arch/x86//kernel/tsc_sync.c: In function 'check_tsc_sync_source':
>> arch/x86//kernel/tsc_sync.c:367:3: error: implicit declaration of function 'pr_warning'; did you mean 'pr_warn'? [-Werror=implicit-function-declaration]
pr_warning("TSC synchronization [CPU#%d -> CPU#%d]:\n",
^~~~~~~~~~
pr_warn
cc1: some warnings being treated as errors
--
arch/x86//kernel/setup_percpu.c: In function 'setup_per_cpu_areas':
>> arch/x86//kernel/setup_percpu.c:210:4: error: implicit declaration of function 'pr_warning'; did you mean 'pr_warn'? [-Werror=implicit-function-declaration]
pr_warning("%s allocator failed (%d), falling back to page size\n",
^~~~~~~~~~
pr_warn
cc1: some warnings being treated as errors
--
arch/x86//kernel/apic/apic.c: In function 'calibrate_by_pmtimer':
>> arch/x86//kernel/apic/apic.c:783:2: error: implicit declaration of function 'pr_warning'; did you mean 'acpi_warning'? [-Werror=implicit-function-declaration]
pr_warning("APIC calibration not consistent "
^~~~~~~~~~
acpi_warning
cc1: some warnings being treated as errors
--
drivers//acpi/resource.c: In function 'acpi_dev_get_irqresource':
>> drivers//acpi/resource.c:416:4: error: implicit declaration of function 'pr_warning'; did you mean 'acpi_warning'? [-Werror=implicit-function-declaration]
pr_warning("ACPI: IRQ %d override to %s, %s\n", gsi,
^~~~~~~~~~
acpi_warning
cc1: some warnings being treated as errors
vim +581 drivers/platform/x86/eeepc-laptop.c
2b121bc262fa03 Corentin Chary 2009-06-25 560
14fdb152416c0f Matthew Garrett 2011-05-09 561 static void eeepc_rfkill_hotplug(struct eeepc_laptop *eeepc, acpi_handle handle)
5740294ca3a9b1 Matthew Garrett 2009-01-20 562 {
14fdb152416c0f Matthew Garrett 2011-05-09 563 struct pci_dev *port;
5740294ca3a9b1 Matthew Garrett 2009-01-20 564 struct pci_dev *dev;
6d41839e762f8b Alan Jenkins 2009-08-28 565 struct pci_bus *bus;
854c78363f37f0 Alan Jenkins 2009-12-03 566 bool blocked = eeepc_wlan_rfkill_blocked(eeepc);
bc9d24a3aeb153 Alan Jenkins 2010-02-22 567 bool absent;
bc9d24a3aeb153 Alan Jenkins 2010-02-22 568 u32 l;
5740294ca3a9b1 Matthew Garrett 2009-01-20 569
a7624b63fdf50d Alan Jenkins 2009-12-03 570 if (eeepc->wlan_rfkill)
a7624b63fdf50d Alan Jenkins 2009-12-03 571 rfkill_set_sw_state(eeepc->wlan_rfkill, blocked);
6d41839e762f8b Alan Jenkins 2009-08-28 572
a7624b63fdf50d Alan Jenkins 2009-12-03 573 mutex_lock(&eeepc->hotplug_lock);
8b9ec1da6a310b Rafael J. Wysocki 2014-01-10 574 pci_lock_rescan_remove();
dcf443b5813074 Alan Jenkins 2009-08-28 575
125450f814418b Lukas Wunner 2018-09-08 576 if (!eeepc->hotplug_slot.ops)
248d4903639068 Frans Klaver 2014-10-22 577 goto out_unlock;
248d4903639068 Frans Klaver 2014-10-22 578
14fdb152416c0f Matthew Garrett 2011-05-09 579 port = acpi_get_pci_dev(handle);
14fdb152416c0f Matthew Garrett 2011-05-09 580 if (!port) {
14fdb152416c0f Matthew Garrett 2011-05-09 @581 pr_warning("Unable to find port\n");
14fdb152416c0f Matthew Garrett 2011-05-09 582 goto out_unlock;
14fdb152416c0f Matthew Garrett 2011-05-09 583 }
14fdb152416c0f Matthew Garrett 2011-05-09 584
14fdb152416c0f Matthew Garrett 2011-05-09 585 bus = port->subordinate;
14fdb152416c0f Matthew Garrett 2011-05-09 586
5740294ca3a9b1 Matthew Garrett 2009-01-20 587 if (!bus) {
22441ffeed17b9 Joe Perches 2011-03-29 588 pr_warn("Unable to find PCI bus 1?\n");
f661848b74b330 Jiang Liu 2012-09-14 589 goto out_put_dev;
5740294ca3a9b1 Matthew Garrett 2009-01-20 590 }
5740294ca3a9b1 Matthew Garrett 2009-01-20 591
bc9d24a3aeb153 Alan Jenkins 2010-02-22 592 if (pci_bus_read_config_dword(bus, 0, PCI_VENDOR_ID, &l)) {
bc9d24a3aeb153 Alan Jenkins 2010-02-22 593 pr_err("Unable to read PCI config space?\n");
f661848b74b330 Jiang Liu 2012-09-14 594 goto out_put_dev;
bc9d24a3aeb153 Alan Jenkins 2010-02-22 595 }
14fdb152416c0f Matthew Garrett 2011-05-09 596
bc9d24a3aeb153 Alan Jenkins 2010-02-22 597 absent = (l == 0xffffffff);
bc9d24a3aeb153 Alan Jenkins 2010-02-22 598
bc9d24a3aeb153 Alan Jenkins 2010-02-22 599 if (blocked != absent) {
9f662b20d6cef8 Frans Klaver 2014-10-22 600 pr_warn("BIOS says wireless lan is %s, but the pci device is %s\n",
bc9d24a3aeb153 Alan Jenkins 2010-02-22 601 blocked ? "blocked" : "unblocked",
bc9d24a3aeb153 Alan Jenkins 2010-02-22 602 absent ? "absent" : "present");
9f662b20d6cef8 Frans Klaver 2014-10-22 603 pr_warn("skipped wireless hotplug as probably inappropriate for this model\n");
f661848b74b330 Jiang Liu 2012-09-14 604 goto out_put_dev;
bc9d24a3aeb153 Alan Jenkins 2010-02-22 605 }
bc9d24a3aeb153 Alan Jenkins 2010-02-22 606
19d337dff95cbf Johannes Berg 2009-06-02 607 if (!blocked) {
5740294ca3a9b1 Matthew Garrett 2009-01-20 608 dev = pci_get_slot(bus, 0);
5740294ca3a9b1 Matthew Garrett 2009-01-20 609 if (dev) {
5740294ca3a9b1 Matthew Garrett 2009-01-20 610 /* Device already present */
5740294ca3a9b1 Matthew Garrett 2009-01-20 611 pci_dev_put(dev);
f661848b74b330 Jiang Liu 2012-09-14 612 goto out_put_dev;
5740294ca3a9b1 Matthew Garrett 2009-01-20 613 }
5740294ca3a9b1 Matthew Garrett 2009-01-20 614 dev = pci_scan_single_device(bus, 0);
5740294ca3a9b1 Matthew Garrett 2009-01-20 615 if (dev) {
5740294ca3a9b1 Matthew Garrett 2009-01-20 616 pci_bus_assign_resources(bus);
c893d133eaccdd Yijing Wang 2014-05-30 617 pci_bus_add_device(dev);
5740294ca3a9b1 Matthew Garrett 2009-01-20 618 }
5740294ca3a9b1 Matthew Garrett 2009-01-20 619 } else {
5740294ca3a9b1 Matthew Garrett 2009-01-20 620 dev = pci_get_slot(bus, 0);
5740294ca3a9b1 Matthew Garrett 2009-01-20 621 if (dev) {
210647af897af8 Yinghai Lu 2012-02-25 622 pci_stop_and_remove_bus_device(dev);
5740294ca3a9b1 Matthew Garrett 2009-01-20 623 pci_dev_put(dev);
5740294ca3a9b1 Matthew Garrett 2009-01-20 624 }
5740294ca3a9b1 Matthew Garrett 2009-01-20 625 }
f661848b74b330 Jiang Liu 2012-09-14 626 out_put_dev:
f661848b74b330 Jiang Liu 2012-09-14 627 pci_dev_put(port);
dcf443b5813074 Alan Jenkins 2009-08-28 628
dcf443b5813074 Alan Jenkins 2009-08-28 629 out_unlock:
8b9ec1da6a310b Rafael J. Wysocki 2014-01-10 630 pci_unlock_rescan_remove();
a7624b63fdf50d Alan Jenkins 2009-12-03 631 mutex_unlock(&eeepc->hotplug_lock);
5740294ca3a9b1 Matthew Garrett 2009-01-20 632 }
5740294ca3a9b1 Matthew Garrett 2009-01-20 633
:::::: The code at line 581 was first introduced by commit
:::::: 14fdb152416c0fab80ecddf492c129d7da1bb8ef eeepc-laptop: Use ACPI handle to identify rfkill port
:::::: TO: Matthew Garrett <mjg@xxxxxxxxxx>
:::::: CC: Matthew Garrett <mjg@xxxxxxxxxx>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation
Attachment:
.config.gz
Description: application/gzip