Re: [PATCH v1 1/4] powerpc/fixmap: don't clear fixmap area in paging_init()

From: Christophe Leroy
Date: Thu Nov 28 2019 - 03:06:55 EST




Le 27/11/2019 Ã 15:43, Christophe Leroy a ÃcritÂ:


Le 26/11/2019 Ã 02:13, Michael Ellerman a ÃcritÂ:
On Thu, 2019-09-12 at 13:49:41 UTC, Christophe Leroy wrote:
fixmap is intended to map things permanently like the IMMR region on
FSL SOC (8xx, 83xx, ...), so don't clear it when initialising paging()

Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/f2bb86937d86ebcb0e52f95b6d19aba1d850e601


Hi,

What happened ?

It looks like it is gone in today's powerpc next.


I see it back today in powerpc/merge, thanks.

The issue is it is crashing with HIGHMEM, indeed exactly the same as you saw with "[PATCH] powerpc/8xx: Fix permanently mapped IMMR region.", since that was exactly the same code.

I sent a fix for it, and I also rebased "[PATCH] powerpc/8xx: Fix permanently mapped IMMR region." into v2 to exclude from it the already merged part.

It would be wise if you could merge both.

Thanks
Christophe