Re: [v2 PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS_PRIVATE

[Anshuman Khandual]

On 11/27/2019 12:14 AM, Yang Shi wrote:
> The commit 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem)
> FS") introduced a new khugepaged scan result: SCAN_PAGE_HAS_PRIVATE, but
> the corresponding description for trace events were not added.
> 
> Cc: Song Liu <songliubraving@xxxxxx>
> Cc: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Cc: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx>
> ---
> v2: *Adopted the comments from Anshuman Khandual

Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>

> 
>  include/trace/events/huge_memory.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
> index dd4db33..d82a0f4 100644
> --- a/include/trace/events/huge_memory.h
> +++ b/include/trace/events/huge_memory.h
> @@ -31,7 +31,8 @@
>  	EM( SCAN_ALLOC_HUGE_PAGE_FAIL,	"alloc_huge_page_failed")	\
>  	EM( SCAN_CGROUP_CHARGE_FAIL,	"ccgroup_charge_failed")	\
>  	EM( SCAN_EXCEED_SWAP_PTE,	"exceed_swap_pte")		\
> -	EMe(SCAN_TRUNCATED,		"truncated")			\
> +	EM( SCAN_TRUNCATED,		"truncated")			\
> +	EMe(SCAN_PAGE_HAS_PRIVATE,	"page_has_private")		\
>  
>  #undef EM
>  #undef EMe
>