Re: [PATCH v1] mm/memory_hotplug: don't check the nid in find_(smallest|biggest)_section_pfn

[David Hildenbrand]

On 28.11.19 16:29, Qian Cai wrote:
> 
> 
>> On Nov 28, 2019, at 9:52 AM, David Hildenbrand <david@xxxxxxxxxx> wrote:
>>
>> I also agree that it should not be used for basic functional/compile
>> tests (I said "It is a way of giving patches *more* testing."). It
>> should not be the only place to test stuff (especially to let somebody
>> else do it).
>>
>> However, sometimes we really have to get additional test coverage via
>> linux-next, especially for weird archs/configurations/setups.
>>
>> ... and if we don't have enough reviewers, it's really hard to get stuff
>> upstream.
>>
>> I wish MM patches would get reviewed more thoroughly.
>>
>> (If we all make a wish, maybe Santa Clause will listen ;) )
> 
> What I donât understand is that we have an policy prohibiting code churn like code optimization in cold path, but allow those micro cleanup of code. Those cleanup also tend to be unregulated and is subject to personal tastes (for example, your CS teachers may have a different taste from mine). I can understand developers want to have fun, but perhaps there are other playground areas that worth taking more risk? 
> 

I said all I had to say about this topic, especially also why cleanups
and refactorings are important. No, you won't change the way I (and most
other people here) work, sorry.

-- 
Thanks,

David / dhildenb