Re: [i4passt] [PATCH 1/5] staging/qlge: remove initialising of static local variable

From: Tobias Langer
Date: Fri Nov 29 2019 - 02:24:48 EST


Hi,

the patch series looks fine to me, I think you can go ahead and send it
to the kernel.

Kind regards
Tobias

On 27.11.19 13:30, Dorothea Ehrl wrote:
> This patch fixes "ERROR: do not initialise statics to 0" by checkpatch.pl.
>
> Signed-off-by: Dorothea Ehrl <dorothea.ehrl@xxxxxx>
> Co-developed-by: Vanessa Hack <vanessa.hack@xxxxxx>
> Signed-off-by: Vanessa Hack <vanessa.hack@xxxxxx>
> ---
> drivers/staging/qlge/qlge_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index 6ad4515311f7..587102aa7fbf 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -4578,7 +4578,7 @@ static int qlge_probe(struct pci_dev *pdev,
> {
> struct net_device *ndev = NULL;
> struct ql_adapter *qdev = NULL;
> - static int cards_found = 0;
> + static int cards_found;
> int err = 0;
>
> ndev = alloc_etherdev_mq(sizeof(struct ql_adapter),
> --
> 2.20.1
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature