Re: [PATCH v2 5/5] rtc: rtc-rc5t619: add ricoh rc5t619 RTC driver

[Alexandre Belloni]

On 29/11/2019 07:59:40+0100, Andreas Kemnade wrote:
> > > +	/* disable interrupt */
> > > +	err = rc5t619_rtc_alarm_enable(&pdev->dev, 0);
> > > +	if (err)
> > > +		return err;  
> > 
> > Is it really useful to disable the alarm to reenable them later?
> > 
> Well, yes, seems to be nonsense.
> Am I right that I do not need to prevent alarm irqs between
> alloc() and register()?
> 

That's fine, the core will be ready to handle alarms after alloc()


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com